- Added canonical selection utility resolver and mode mapping:#193
Merged
- Added canonical selection utility resolver and mode mapping:#193
Conversation
- pairing_trueskill_u0
- pairing_trueskill_u
- linking_cross_set_p_times_1_minus_p
- NA
- Files: R/adaptive_select.R, R/adaptive_step.R
- Replaced linking ordering’s column-presence behavior with resolver-driven utility selection and explicit
deterministic fallback when selected utility is fully non-finite (fallback to u0, then lexical tie-break).
- File: R/adaptive_round_candidates.R
- Updated step logging semantics:
- utility_mode now comes from resolved selection mode, not controller$cross_set_utility.
- cross_set_utility_pre is populated only for linking-mode cross-set evaluation path.
- Non-cross-set rows may carry pairing utility modes.
- File: R/adaptive_step.R
- Hardened utility config handling to canonical linking utility naming (with legacy alias normalization).
- File: R/adaptive_state.R
- Made linking inference contract explicit as MAP + Hessian/Laplace approximation in linking refit contract metadata
and comments.
- File: R/adaptive_btl_refit.R
- Reconciled roxygen docs to mode-specific utility semantics and removed stale cross_set_utility wording from
exported docs sections.
- File: R/adaptive_run.R
- Generated docs: man/adaptive_rank_start.Rd, man/adaptive_rank_run_live.Rd
- Added/updated tests for:
- new utility_mode values,
- pairing-vs-linking utility separation,
- deterministic non-finite linking utility fallback,
- independent spoke stage progress isolation check.
- Files:
- tests/testthat/test-5011-run-one-step-transactional.R
- tests/testthat/test-5048-linking-phase-a-artifacts.R
- tests/testthat/test-5049-linking-candidates-round-routing.R
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- pairing_trueskill_u
- linking_cross_set_p_times_1_minus_p
- NA
- Files: R/adaptive_select.R, R/adaptive_step.R
deterministic fallback when selected utility is fully non-finite (fallback to u0, then lexical tie-break).
and comments.
exported docs sections.